Open
Conversation
clue
requested changes
Feb 23, 2020
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
The test failures seem to be unrelated afaict?
The PHP 7.4 build reports plenty of warning because it's using an outdated PHPUnit version, so this should probably be updated as part of this PR 👍
Member
Author
They are, #79 will deal with those.
Working on bumping it to the latest version, takes some more changes then I hope for 😂 |
WyriHaximus
force-pushed
the
travis-php-7.3-and-7.4
branch
4 times, most recently
from
80ef142 to
2010a9b
Compare
And drop old PHP versions that don't support the new mock method
WyriHaximus
force-pushed
the
travis-php-7.3-and-7.4
branch
from
2010a9b to
f2a4dfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.